Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@leoebfolsom
Copy link
Contributor

Small edits to the README as described/discussed here.

  • quotes around Snowflake URI
  • a note about capitalizing Snowflake table and schema names, and a general advisory about case sensitivity
  • 🥕 around user-inputted arguments in the database table

Copy link
Contributor

@sirupsen sirupsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, otherwise LGTM. Since get params aren't used in the others, I agree it's not necessary.

@erezsh should sign off too

Copy link
Contributor

@erezsh erezsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm okay with this PR.

See one comment that needs to be addressed.

@erezsh erezsh merged commit 42795b5 into datafold:master Jun 28, 2022
@leoebfolsom leoebfolsom deleted the lf/update_readme_snowflake branch June 28, 2022 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants